Skip to content

add device pulling example#74

Open
Quadraplex-T3000 wants to merge 2 commits into
mainfrom
feat/deviceConfigExample
Open

add device pulling example#74
Quadraplex-T3000 wants to merge 2 commits into
mainfrom
feat/deviceConfigExample

Conversation

@Quadraplex-T3000
Copy link
Copy Markdown

No description provided.

@Quadraplex-T3000 Quadraplex-T3000 requested a review from a team as a code owner April 30, 2026 19:10
@snyk-io
Copy link
Copy Markdown

snyk-io Bot commented Apr 30, 2026

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues
Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

Copy link
Copy Markdown
Contributor

@JackHowa JackHowa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The script appears incomplete — device_list = [] is hardcoded empty so the core logic never runs. argparse is imported but never used (no ArgumentParser, no arguments defined, no parse_args() call), suggesting CLI input was intended but not implemented. The script needs a way to pass in the device list before it is usable as an example.

A few other things to clean up while you are at it:

  • import pdb left in (debugger import, unused)
  • via_siem_config_inventory = {} defined but never used
  • Bare except: should be except Exception as e: to avoid swallowing KeyboardInterrupt etc.
  • Module docstring references poll_device_health.py — looks like a copy-paste from another script

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants